Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TimeColumn -> IndexColumn and assorted fixes #7636

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 8, 2024

What

  • Rename had not been completed
  • Discovered column names aren't being assigned properly while testing

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs requested a review from abey79 October 8, 2024 14:38
@jleibs jleibs added feat-dataframe-api Everything related to the dataframe API include in changelog labels Oct 8, 2024
@jleibs jleibs marked this pull request as ready for review October 8, 2024 14:38
@jleibs jleibs added 🐍 Python API Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md and removed include in changelog labels Oct 8, 2024
@jleibs jleibs merged commit 5852681 into main Oct 8, 2024
34 checks passed
@jleibs jleibs deleted the jleibs/dataframe_api_fixes branch October 8, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants