Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance for scenes with many entities & transforms #7456

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 20, 2024

What

Not super significant unfortunately, in one badly affected scene I went from ~130ms to ~110ms. It's probably better in those that aren't using any transforms at all.
We need to do some more general overhaul there and imho at that point we might as well start thinking more seriously about range queries for transforms. See among others:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide
  • run checklists & samples to check if transforms still work fine

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 📉 performance Optimization, memory use, etc include in changelog labels Sep 20, 2024
@Wumpf Wumpf force-pushed the andreas/transform-perf-improvements branch from 720d695 to 3af1f83 Compare September 24, 2024 11:28
@Wumpf Wumpf merged commit 7c7c712 into main Sep 24, 2024
33 of 35 checks passed
@Wumpf Wumpf deleted the andreas/transform-perf-improvements branch September 24, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 📉 performance Optimization, memory use, etc 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants