Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chunk::component_batch_raw not checking the bitmap first #7286

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Aug 27, 2024

@abey79 discovered the issue when doing the Chunk Store UI.

Before:
image

After:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself include in changelog labels Aug 27, 2024
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't component_batch() (and possibly component_instance[_raw]() receive the same treatment?

@teh-cmc
Copy link
Member Author

teh-cmc commented Aug 27, 2024

Shouldn't component_batch() (and possibly component_instance[_raw]() receive the same treatment?

Everything bottoms out in component_batch_raw ultimately so that shouldn't be a problem.

That makes me wonder if there are similar shenanigans on UnitChunk though.

@abey79
Copy link
Member

abey79 commented Aug 27, 2024

Oh right, didn't notice.

@teh-cmc
Copy link
Member Author

teh-cmc commented Aug 27, 2024

There were in fact similar shenaniganeries on UnitChunk, nice catch

@teh-cmc teh-cmc merged commit e13b389 into main Aug 27, 2024
30 checks passed
@teh-cmc teh-cmc deleted the cmc/buggy_batch_raw branch August 27, 2024 16:18
@emilk emilk added this to the 0.18.1 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants