Skip to content

Speed up data density graph by rendering them more coarsly #7229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Speed up data density graph by rendering them more coarsly #7229

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b2a836
Switch to chunk-rendering earlier in streams view
emilk Aug 19, 2024
423458b
Check that the correct timeline is sorted
emilk Aug 19, 2024
0764fe2
Add profile scope
emilk Aug 19, 2024
341bb47
Add disabled debug-painter to data_density_graph
emilk Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions crates/viewer/re_time_panel/src/data_density_graph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ const MARGIN_X: f32 = 2.0;
/// Higher = slower, but more accurate.
const DENSITIES_PER_UI_PIXEL: f32 = 1.0;

const DEBUG_PAINT: bool = false;

// ----------------------------------------------------------------------------

/// Persistent data for painting the data density graph.
Expand Down Expand Up @@ -477,9 +479,22 @@ pub fn build_density_graph<'a>(

let can_render_individual_events = total_events < config.max_total_chunk_events;

if DEBUG_PAINT {
ui.ctx().debug_painter().debug_rect(
row_rect,
egui::Color32::LIGHT_BLUE,
format!(
"{} chunks, {total_events} events, render individual: {can_render_individual_events}",
chunk_ranges.len()
),
);
}

for (chunk, time_range, num_events_in_chunk) in chunk_ranges {
re_tracing::profile_scope!("chunk_range");

let should_render_individual_events = can_render_individual_events
&& if chunk.is_time_sorted() {
&& if chunk.is_timeline_sorted(&timeline) {
num_events_in_chunk < config.max_events_in_sorted_chunk
} else {
num_events_in_chunk < config.max_events_in_unsorted_chunk
Expand Down Expand Up @@ -544,8 +559,8 @@ impl Default for DensityGraphBuilderConfig {
// It does not seem to matter how many chunks there are, only how many total events we're showing.
//
// We want to stay around 1ms if possible, preferring to instead spend our frame budget on actually
// visualizing the data, so we undershoot the limit here by a good amount:
max_total_chunk_events: 50_000,
// visualizing the data, and we also want to support multiple data density graphs on the screen at once.
max_total_chunk_events: 10_000,

// For individual chunks, the limits are completely arbitrary, and help preserve visual clarity of the data
// when there are too many events in a given chunk.
Expand Down
Loading