Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when trying to clear non-existent component #7215

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 16, 2024

What

Changed the semantics of the method from "log empty" to "clear" which is what we actually want in all cases. Being a clear, it's no longer an error if there's nothing there to begin with as we don't have to write anything then.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Aug 16, 2024
@Wumpf Wumpf merged commit 03c0d9a into main Aug 16, 2024
34 of 35 checks passed
@Wumpf Wumpf deleted the andreas/fix-unknown-component-error branch August 16, 2024 13:05
@teh-cmc teh-cmc changed the title Fix error when trying to clear non-existant component Fix error when trying to clear non-existent component Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clearing component with unknown type errors when using reset to default blueprint button on tensor view
2 participants