Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize gap detector on dense timelines, like log_tick #7082

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Optimize gap detector on dense timelines, like log_tick #7082

merged 1 commit into from
Aug 7, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 6, 2024 •
edited by github-actions bot
Loading

What

We hit a specially bad case looking for small gaps on dense timeliens, like on log_tick.

The new code does an early-out when the gap we're looking for becomes much smaller than the total time of the (non-gap) data.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk
Optimize gap finding
0fc17a2 
We hit a specially bad case looking for small gaps on dense timeliens,
like on `log_tick`.

The new code does an early-out when the gap we're looking for
becomes much smaller than the total time of the (non-gap) data.
@emilk emilk added 🚀 performance Optimization, memory use, etc include in changelog labels Aug 6, 2024
@emilk emilk changed the title Optimize gap finding on dense timelines, like log_tick Optimize gap detector on dense timelines, like log_tick Aug 6, 2024
@teh-cmc teh-cmc self-requested a review August 7, 2024 07:05
@emilk emilk merged commit afa7490 into main Aug 7, 2024
36 of 37 checks passed
@emilk emilk deleted the emilk/optimize-gap-finder branch August 7, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
include in changelog 🚀 performance Optimization, memory use, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time panel gap-detector very slow in VRS example on log_tick timeline
2 participants
@emilk @teh-cmc