-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small chunk heuristics for data density graph #6905
Conversation
How I read the benchmark results is that it doesn't matter how the chunks are rendered, it scales with how many total events there are. As expected, unsorted data is slower to process. What I don't understand is why splitting chunks seems to do... nothing? The difference between Benchmark results on my machine:
|
The code to disable the individual point rendering was wrong, new results make a lot more sense:
On my machine, building a graph consisting of 100k events costs around 1.5ms, so I think it's a good threshold.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a bug in num_events_cumulative_per_unique_time
What
The data density graph now renders individual events if it is not prohibitively expensive.
TimeHistogram
#6065Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.