-
Notifications
You must be signed in to change notification settings - Fork 532
Add Ellipsoids3D
archetype.
#6853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bb3ee81
Add `Ellipsoids` archetype, visualizer, and snippets.
kpreid 2f04451
Ack cargo-deny duplicate detection.
kpreid a69cf29
Add `Ellipsoids` to docs sections.
kpreid 2581b21
Fix doc link.
kpreid ab7080c
Fix C++ paste-o.
kpreid 117b226
Re-codegen.
kpreid d74f18e
Merge branch 'main' of https://github.com/rerun-io/rerun into ellipsoids
kpreid d29ea51
Fix mention of “boxes”
kpreid 3c3b0dd
Use fixed subdivisions as a placeholder.
kpreid ea6af78
Merge branch 'main' of https://github.com/rerun-io/rerun into ellipsoids
kpreid 4c2d341
Hide TODO from docs and re-codegen
kpreid aecdd4d
Apply suggestions from code review
kpreid 52298f6
Update note on hexasphere lines bug.
kpreid 4f003ab
Remove glam multi-version workaround
kpreid 9ad178d
Add and use `HalfSize3D::splat`.
kpreid d672869
Correct bounding box
kpreid dd054ab
Don't pass `half_sizes` to `process_labels`.
kpreid 9357697
Put radii constructors first. Add "sphere" keyword.
kpreid 6aa20e5
Re-codegen.
kpreid 3dc41c2
Merge branch 'main' into ellipsoids
emilk 6c7c1d0
Python: Export Ellipsoids
emilk 080dd4a
Use a much more coarse mesh by default
emilk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
crates/store/re_types/definitions/rerun/archetypes/ellipsoids.fbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
include "fbs/attributes.fbs"; | ||
include "rust/attributes.fbs"; | ||
include "cpp/attributes.fbs"; | ||
|
||
include "rerun/datatypes.fbs"; | ||
include "rerun/components.fbs"; | ||
|
||
namespace rerun.archetypes; | ||
|
||
// --- | ||
|
||
/// 3D ellipsoids or spheres. | ||
/// | ||
/// This archetype is for ellipsoids or spheres whose size is a key part of the data | ||
/// (e.g. a bounding sphere). | ||
/// For points whose radii are for the sake of visualization, use `Points3D` instead. | ||
/// | ||
/// Currently, ellipsoids are always rendered as wireframes. | ||
/// Opaque and transparent rendering will be supported later. | ||
/// | ||
/// \example archetypes/ellipsoid_batch !api title="Batch of ellipsoids" | ||
table Ellipsoids ( | ||
"attr.rust.derive": "PartialEq", | ||
"attr.rust.new_pub_crate", | ||
"attr.cpp.no_field_ctors", | ||
"attr.docs.category": "Spatial 3D", | ||
"attr.docs.view_types": "Spatial3DView, Spatial2DView: if logged above active projection" | ||
) { | ||
// --- Required --- | ||
|
||
/// For each ellipsoid, half of its size on its three axes. | ||
/// | ||
/// If all components are equal, then it is a sphere with that radius. | ||
half_sizes: [rerun.components.HalfSize3D] ("attr.rerun.component_required", order: 1000); | ||
kpreid marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
// --- Recommended --- | ||
|
||
/// Optional center positions of the ellipsoids. | ||
/// | ||
/// If not specified, the centers will be at (0, 0, 0). | ||
centers: [rerun.components.Position3D] ("attr.rerun.component_recommended", nullable, order: 2000); | ||
|
||
/// Optional rotations of the ellipsoids. | ||
/// | ||
/// If not specified, the axes of the ellipsoid align with the axes of the coordinate system. | ||
rotations: [rerun.components.Rotation3D] ("attr.rerun.component_recommended", nullable, order: 2100); | ||
|
||
/// Optional colors for the ellipsoids. | ||
colors: [rerun.components.Color] ("attr.rerun.component_recommended", nullable, order: 2200); | ||
|
||
// --- Optional --- | ||
|
||
/// Optional radii for the lines used when the ellipsoid is rendered as a wireframe. | ||
line_radii: [rerun.components.Radius] ("attr.rerun.component_optional", nullable, order: 3000); | ||
|
||
/// Optional text labels for the ellipsoids. | ||
labels: [rerun.components.Text] ("attr.rerun.component_optional", nullable, order: 3100); | ||
|
||
/// Optional `ClassId`s for the ellipsoids. | ||
/// | ||
/// The class ID provides colors and labels if not specified explicitly. | ||
class_ids: [rerun.components.ClassId] ("attr.rerun.component_optional", nullable, order: 3200); | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.