-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunkify time panel data density graphs #6847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good first step! But I think we should consider entity-level APIs for Chunks to make this code less awkward and more performant
I think it would be great with some test code for this, testing different scenarios:
Of course, to properly test this, one has to turn off the compaction in the viewer somehow |
Compaction can be disabled either via rerun/crates/store/re_chunk_store/src/store.rs Lines 96 to 115 in 2342e2b
|
I'm not sure I understand the UX here. I open https://rerun.io/viewer/pr/6847?url=https%3A%2F%2Fapp.rerun.io%2Fversion%2Fnightly%2Fexamples%2Fnuscenes_dataset.rrd and then hover randomly over the time panel and I cannot quite make sense of the behaviour. Sometimes I get an hover pop-up, sometimes not, I'm not sure why? 24-07-11_15.07.47.patched.mp4Am I missing something? |
Updated after design call with Katya and @emilk:
For testing, I added |
Double-clicking to reset the pan/zoom of the streams panel view no longer works |
When hovering something in a chunk I want to know when in time the thing I hover is at. I think the individual time-point of the latest-at query should be shown in the tooltip, but also visually. For the visually part I think either that's where the time-cursor snaps to on hover, or we add a circle or something to highlight when that time-point is. Both these can wait for a later PR though, but definitely before we switch to the new chunk design. |
Should be working now. I also feature-gated the new behavior, should've been done from the start. This feels like something that should eventually be added to the release checklist. I tested:
The last part is new and slightly strange, because previously you couldn't just click anywhere on the time area to set time. Now you can, which has this side effect. I don't dislike it, but I don't know how I'd get it working as it did previously if it is an issue. |
What
Part 1 of:
TimeHistogram
#6065This adds a new option,
Chunk-based data density graph
, which when enabled switches the timeline from rendering usingTimeHistogram
to rendering chunks directly, using range queries in the UI code.To test, enable
Options -> Chunk-based data density graph
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.