Fix incorrect label placement for 3D arrows with origins #6779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
approved these changes
Jul 4, 2024
emilk
pushed a commit
that referenced
this pull request
Jul 5, 2024
### What Title says 3D because that's what this fixes compard to 0.16. However, on `main` both was broken. What happend? On 0.16.1 * arrows2d: note no incorrect paranthesis https://github.com/rerun-io/rerun/blob/release-0.16.1/crates/re_space_view_spatial/src/visualizers/arrows2d.rs#L66 * arrows3d: note incorrect paranthesis https://github.com/rerun-io/rerun/blob/release-0.16.1/crates/re_space_view_spatial/src/visualizers/arrows3d.rs#L66 Recently I did a refactor of label positioning code and ended up propagating the broken code to 2D arrows. Which then in turn was noticed by @teh-cmc as it broke a recently added release checklist item. <img width="1021" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/7704df11-87eb-469c-acfa-890889942630"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6779?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6779?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6779) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
emilk
added a commit
that referenced
this pull request
Jul 8, 2024
### Next steps
- Test the release
- If this is an 'alpha' release, you can just merge the pull request.
- Otherwise:
- For any added commits, run the release workflow in 'rc' mode again
- After testing, _ensure that this PR is mergeable to _, then run the
release workflow in 'release' mode
- Once the final release workflow finishes it will create a GitHub
release for you. Then:
- [x] Sanity check the build artifacts:
- [x] pip install: does it install and run?
- [x] cargo install of cli tool: does it install and run?
- [x] C++ SDK zip: does it contain rerun_c for all platforms?
- [x] Populate the release with the changelog and a nice header
video/picture, check , then click .
- [ ] Make sure the [conda feedstock
PR](https://github.com/conda-forge/rerun-sdk-feedstock/pulls) gets
merged. This will be created by the once the GitHub release is created.
- [x] Update the [google colab
notebooks](https://drive.google.com/drive/folders/0AC0q24MFKh3fUk9PVA)
to install this version and re-execute the notebook.
- [ ] Merge this PR
### TODO
- [x] make sure the changelog.md date is correct
- [x] migration guide
- [x] docs update
- [x] mainly mentions/links to the viz/override docs where appropriate
- [x] remove speculative link markers
- [x] including all `attr.docs.unreleased`
- [x] cherrypick:
- [x] #6771
- [x] #6768
- [x] #6781
- [x] #6779
- [x] #6782
- [x] #6783
- [x] make sure nothing is left to be cherry-picked
- [x] Tests
- [x] Windows
- [x] Linux
- [x] MacOS
---------
Co-authored-by: Antoine Beyeler <[email protected]>
Co-authored-by: Antoine Beyeler <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: Andreas Reich <[email protected]>
Co-authored-by: jprochazk <[email protected]>
Co-authored-by: Leonard Bruns <[email protected]>
Co-authored-by: Clement Rey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Title says 3D because that's what this fixes compard to 0.16. However, on
mainboth was broken.What happend?
On 0.16.1
Recently I did a refactor of label positioning code and ended up propagating the broken code to 2D arrows. Which then in turn was noticed by @teh-cmc as it broke a recently added release checklist item.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.