Skip to content

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jul 4, 2024

// NOTE: Do not carry the extension metadata beyond the FFI barrier in order the match the
// data sent by other SDKs.
//
// We've stopped using datatype extensions overall, as they generally have been creating more
// problems than they have solved.
//
// With the addition of `Chunk` and `ChunkMetadata`, it is likely that we will get rid of extension types
// entirely at some point, since it looks like we won't have any use for them anymore.
//
// Doing so will require a more extensive refactoring of the Python SDK though, so until we're absolutely
// certain where we're going, this is a nice, painless and easily reversible solution.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🪳 bug Something isn't working 🔨 testing testing and benchmarks sdk-python Python logging API include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Jul 4, 2024
@teh-cmc teh-cmc merged commit 1fa1d6b into main Jul 5, 2024
@teh-cmc teh-cmc deleted the cmc/ffi_extensions branch July 5, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages sdk-python Python logging API 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in usage of Extension types between python and rust
1 participant