Skip to content

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Jun 25, 2024

What

Previously the viewer would not be initialized until the end of cell execution, creating an awkward 2-step process.

Some notes in the anywidget discord got me enough info to hypothesize that something like https://github.com/Kirill888/jupyter-ui-poll might exist... and it works!

By default Viewer.display will now call the new helper that blocks until initialization is complete.

I also decided that display=True on the widget constructor was a little bit odd and changed this to just use Viewer.display().

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added notebook Jupyter notebooks etc include in changelog labels Jun 25, 2024
@jleibs jleibs marked this pull request as ready for review June 25, 2024 13:42
Copy link

github-actions bot commented Jun 25, 2024

Deployed docs

Commit Link
e8a1c6f https://landing-58lse3goq-rerun.vercel.app/docs

@jleibs jleibs added the sdk-python Python logging API label Jun 25, 2024
Copy link
Member

@jprochazk jprochazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jleibs jleibs added the do-not-merge Do not merge this PR label Jun 25, 2024
@jleibs jleibs removed the do-not-merge Do not merge this PR label Jun 25, 2024
@jleibs jleibs merged commit 62684bd into main Jun 25, 2024
@jleibs jleibs deleted the jleibs/notebook_incremental_stream branch June 25, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog notebook Jupyter notebooks etc sdk-python Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants