Revert making web_viewer a default feature of rerun_py #6370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In #6335
web_viewer
became a default feature ofrerun_py
.This caused a bunch of issues for development:
pixi run py-build
builds with default features and doesn't build new wasm blobs, meaning that the build either fails or picks up outdatedQ: Are we sure that wheel publish would still include the web_viewer?
A: Yes. We test this prior to release. This works because we use the
pypi
feature ofbuild_and_upload_wheels.py
. This script also ensures that the wasm blobs are built.Q: Why does the non-contributor ci build the wasm blobs?
A: It doesn't! Again, we use
build_and_upload_wheels.py
there which builds with--no-default-features
. However, that script can't be used on the contributor ci since that would spill the GCS secrets (upload on that script is not optional right now).=> Alternative solutions:
--no-default-features
onpixi run py-build
and on the contributor ci (potentially by using and adjustingbuild_and_upload_wheels.py
pixi run py-build
slower by making it depend on the web buildChecklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.