Don't log warnings when unknown clients connect over TCP #6368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
📺 re_viewer
5 tasks
emilk
pushed a commit
that referenced
this pull request
May 20, 2024
### What The mechanism for identifying Rerun clients was implemented in #6204. However, during the release I accidentally "fixed" the build of `cargo build -p re_viewer --no-default-features` twice: * The seemingly correct fix was to depend on `re_sdk_comms` with the `server` feature always enabled. * The definitely wrong thing that slipped through is to feature guard the section that needs the `re_sdk_comms` server errors with `#[cfg(feature = "server")]`. But `re_viewer` doesn't have a `server` feature, disabling this effectively. This was reverted in #6368 It's up to users of `re_viewer` to allow the serve feature, making `re_viewer` agonistic of the presence of this error type in its smart channel. Therefore I now moved out the error type to `re_sdk_comms` lib.rs so that `re_viewer` doesn't have to depend on the `re_sdk_comms`'s server feature. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6369?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6369?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6369) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
abey79
pushed a commit
that referenced
this pull request
May 28, 2024
* Closes #5883 * [x] I know how checkboxes work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Rerun TCP protocol should be more structured and only log warnings if the incoming connection is from a Rerun SDK #5883
I know how checkboxes work