Transmit url analytics correctly for rerun.io domains #6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
📊 analytics
jprochazk
approved these changes
May 14, 2024
|
|
||
| /// Given a URL, extract the root domain. | ||
| fn extract_root_domain(url: &str) -> Option<String> { | ||
| let parsed = Url::parse(url).ok()?; |
There was a problem hiding this comment.
Side note: I really dislike how there's no borrowed version of Url
There was a problem hiding this comment.
Ha. Yeah, I was trying for a bit to implement the root-domain extraction as a slice before I realized Url wasn't borrowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves:
urldata for domains other thanrerun.io#6288I added the processing at the last stage of the analytics output so we don't depend on every code path possibily populating the analytics event to do its own domain evaluation and/or hashing.
Validated events look correct in posthog:
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.