Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Preserve history state #6302

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix: Preserve history state #6302

merged 2 commits into from
May 13, 2024

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented May 13, 2024

What

Instead of setting state to null, try to preserve existing state.
This helps with ensuring JS frameworks can continue to do their own client-side routing.
If we ever need to store anything in state, we should rethink how we handle this.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jprochazk jprochazk added 🕸️ web regarding running the viewer in a browser include in changelog labels May 13, 2024
@jprochazk jprochazk requested a review from emilk May 13, 2024 11:53
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@emilk emilk merged commit 2f41026 into main May 13, 2024
35 of 36 checks passed
@emilk emilk deleted the jan/preserve-history-state branch May 13, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants