Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the blueprint schema when we try to activate a blueprint sent from SDK #6283

Merged
merged 3 commits into from
May 10, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented May 9, 2024

What

We already used to validate on load from file, but this pulls the validation into the default/activation pathways.
This keeps us from getting into a state where we can't write to the blueprint due to components with inconsistent schemas.

Unfortunately we can still get issues when opening 0.16 blueprints in 0.15 viewers since 0.15 is missing this validation.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added the 🟦 blueprint The data that defines our UI label May 9, 2024
@jleibs jleibs marked this pull request as ready for review May 9, 2024 20:57
@jleibs jleibs merged commit 3a42904 into main May 10, 2024
34 of 35 checks passed
@jleibs jleibs deleted the jleibs/validate_blueprint_on_activate branch May 10, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants