Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when using an under-powered GPU #6252

Merged
merged 2 commits into from
May 10, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 7, 2024

What

Using scripts/fetch_crashes.py to look at our analytics, I noticed that missing wgpu capabilities would lead to a assert/panic, which is not a nice way to report errors to users.

I added an egui issue to improve this further in the future:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ui concerns graphical user interface 🔺 re_renderer affects re_renderer itself include in changelog labels May 7, 2024
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@emilk emilk merged commit efba98a into main May 10, 2024
34 checks passed
@emilk emilk deleted the emilk/report-wgpu-errors branch May 10, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🔺 re_renderer affects re_renderer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants