New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rare crash #6251

Merged

Wumpf merged 1 commit into main from emilk/fix-rare-crash

May 8, 2024

Member

emilk commented May 7, 2024 •

edited by github-actions bot

Loading

Remove an unwrap() that sometimes caused crashes.

Found with scripts/fetch_crashes.py (analytics)

See Forbid unwrap() in our code #3408

Checklist

I have read and agree to Contributor Guide and the Code of Conduct
I've included a screenshot or gif (if applicable)
I have tested the web demo (if applicable):
- Using examples from latest main build: rerun.io/viewer
- Using full set of examples from nightly build: rerun.io/viewer
The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.


          Remove an unwrap() that sometimes caused crashes

Found with `scripts/fetch_crashes.py`

* See #3408

emilk added 🪳 bug 💣 crash include in changelog labels

emilk marked this pull request as ready for review

May 7, 2024 11:03

abey79 approved these changes

View reviewed changes

Wumpf merged commit bda1db0 into main

37 checks passed

Wumpf deleted the emilk/fix-rare-crash branch

May 8, 2024 08:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug 💣 crash include in changelog