-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve new time_ranges property python api & add snippet for time series view, explaining all its options #6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
📖 documentation
Improvements or additions to documentation
🐍 Python API
Python logging API
include in changelog
labels
May 3, 2024
Deployed docs
|
Wumpf
force-pushed
the
andreas/nicer-time-range-api
branch
from
May 3, 2024 16:58
b3e6aee
to
6ace680
Compare
This was referenced May 7, 2024
Wumpf
added a commit
that referenced
this pull request
May 8, 2024
…#6259) ### What Part of a train * #6257 * #6258 * ➡️ #6259 Replaces a fair chunk of * #6221 Makes `VisibleTimeRange` a union - the motivator for this pr train in the first place. Adds a roundtrip test that compares the serialization of`VisibleTimeRange` archetype across sdk languages. (the archetype is meant for blueprint only, but I'm simply using the datastore for this comparision) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6259?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6259?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6259) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Wumpf
force-pushed
the
andreas/nicer-time-range-api
branch
from
May 8, 2024 14:21
6ace680
to
39560bb
Compare
Wumpf
force-pushed
the
andreas/nicer-time-range-api
branch
from
May 8, 2024 14:33
39560bb
to
6dab606
Compare
jleibs
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 so much work to get here, but this is awesome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📖 documentation
Improvements or additions to documentation
include in changelog
🐍 Python API
Python logging API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve
VisibleTimeRange
python api and add a snippet for time series view which is the primary (but not sole!) user of this feature.TODO:
TimeRangeBoundary
a union and if we can't or don't want note it down into the fbs file why* think about how to document time range on other places and how to document usage ofVisibleTimeRange
type itself* consider providing several snippets
* update docs on visible time range in the manual with some code examples while we're on it?Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.