Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in origin selection ui #6199

Merged
merged 4 commits into from
May 2, 2024
Merged

Fix bug in origin selection ui #6199

merged 4 commits into from
May 2, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 2, 2024

What

Fixes a cause of non-determinism.

I also opened an issue:

Before:

flicker

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface include in changelog labels May 2, 2024
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

CODE_STYLE.md Outdated Show resolved Hide resolved
Co-authored-by: Antoine Beyeler <[email protected]>
@emilk emilk merged commit 8f17737 into main May 2, 2024
34 checks passed
@emilk emilk deleted the emilk/fix-indeterminism branch May 2, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants