Introduce new mechanism to incrementally drain from a memory_recording #6187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n works correctly with generators across threads.
jleibs
commented
May 2, 2024
| @@ -53,6 +53,14 @@ def num_msgs(self) -> int: | |||
| """ | |||
| return self.storage.num_msgs() # type: ignore[no-any-return] | |||
|
|
|||
| def drain_as_bytes(self) -> bytes: | |||
There was a problem hiding this comment.
Don't love this name but was struggling to come up with a better one.
teh-cmc
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The main piece of work, plumbing through drain was relatively straight-forward.
In addition, when creating an example that roughly models the gradio streaming workflow, I realized it would be helpful to introduce a decorator which simplifies setting up an isolated recording stream, and works with the sort of streaming generators we expect to see with Gradio.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.