Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make visible time range ui aware of latest-at & QueryRange #6176

Merged
merged 2 commits into from
May 2, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 30, 2024

What

Under the hood this is now actually a "query range" ui since it operates directly on QueryRange, but I opted to not call it that in the viewer yet.

The user facing changes are rather subtle

Before:
Defaulting to latest-at:
image
Defaulting to single timestamp:
image

After:
Defaulting to latest-at:
image
Defaulting to single timestamp:
image

Note that today latest-at can only be inherited (via default). You can't actually set it as an override yet (we decided to delay that a bit since it needs even more restructuring and imho we may want to constrain that depending on the view type).

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added enhancement New feature or request 📺 re_viewer affects re_viewer itself include in changelog labels Apr 30, 2024
@teh-cmc teh-cmc self-requested a review May 2, 2024 07:53
@Wumpf
Copy link
Member Author

Wumpf commented May 2, 2024

there's a grammar messup / typo in the tooltip depicted on the last screenshot

@Wumpf Wumpf merged commit 27a4e54 into main May 2, 2024
6 of 9 checks passed
@Wumpf Wumpf deleted the andreas/improve-visible-time-range-ui-messages branch May 2, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants