ListItem 2.0 (part 0): re_ui_example refactor
#6148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
🚜 refactor
emilk
approved these changes
Apr 29, 2024
Merged
5 tasks
abey79
added a commit
that referenced
this pull request
May 2, 2024
…elContent` legacy back-port (#6161) ### What This PR does the following: - Introduces the fundamental content-generic `ListItem` infrastructure (`ListItem`, `trait ListItemContent`, `list_item_scope()`. - Introduces `LabelContent`, a `ListItemContent` implementation which implements the exact same features as the legacy `ListItem`. - Updates `re_ui_example` to demonstrate the use of the new list item, including a fairly extensive clean-up of the right panel code. <img width="411" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/dcd960d8-2fd1-48ed-ba5b-6f36bd35c65c"> <br/> <br/> - Part of #6075 - Follow-up to #6148 - Fixes #5740 ### Limitation and todos - The handling of the X coordinate range for the background highlight needs (introduced here to part with the clip rect hack) needs splitting of to include _all_ full-span widgets: #6156. - The state management currently looks meaningless as state will only be used by the future `PropertyContent`. Funnily, all the state management currently does is what is to be split off as per above :) - Docstrings needs more work (in particular top-level overview) - `ListItem` + `LabelContent` should be deployed wherever we currently use `ListItem` 1.0, which should be then entirely removed. - And of course, we need a two-column `PropertyContent`… ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6161?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6161?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6161) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The first stage of the
ListItem2.0 effort will be to deploy onre_ui_example, which is currently a mess. This pure refactor PR splits it into multiple file as a preparatory step.Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.