Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change background of 2D space views from code and/or UI #6116

Merged
merged 13 commits into from
Apr 26, 2024
Merged

Change background of 2D space views from code and/or UI #6116

merged 13 commits into from
Apr 26, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 25, 2024 •
edited by github-actions bot
Loading

What

Very similar to 3D space views, even using the same gradient by default.
Usage:

rrb.Spatial2DView(origin="/foo", background=[32, 0, 16])

The default background color is still BLACK.

Here the dark gradient is used.
It looks a little bit too much like the 3D space view.
Screenshot 2024-04-25 at 18 12 05

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🟦 blueprint The data that defines our UI include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🐍 Python API Python logging API and removed 🪵 Log & send APIs Affects the user-facing API for all languages labels Apr 25, 2024
@emilk emilk marked this pull request as ready for review April 25, 2024 16:48
@Wumpf Wumpf self-requested a review April 26, 2024 08:21
Wumpf
Wumpf approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

crates/re_types/definitions/rerun/blueprint/components/background_kind.fbs Outdated Show resolved Hide resolved
crates/re_space_view_spatial/src/lib.rs Show resolved Hide resolved
crates/re_space_view_spatial/src/space_view_2d.rs Outdated Show resolved Hide resolved
crates/re_space_view_spatial/src/lib.rs Outdated Show resolved Hide resolved
crates/re_types/definitions/rerun/blueprint/archetypes/background.fbs Outdated Show resolved Hide resolved
@emilk
Copy link
Member Author

emilk commented Apr 26, 2024

CI failure unrelated to this PR

@emilk emilk merged commit c203d4e into main Apr 26, 2024
36 of 37 checks passed
@emilk emilk deleted the emilk/2d-background branch April 26, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable background color for 2D spatial space view
2 participants
@emilk @Wumpf