-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose PlotLegend
and ScalarAxis
(axis_y) properties on TimeSeriesView
blueprint
#6114
Conversation
Deployed docs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to describe in the PR how a user can set these properties from code. They will want to know when they click the PR link in the changelog!
"attr.rust.repr": "transparent", | ||
"attr.rust.tuple_struct" | ||
) { | ||
lock_range: bool (order: 100); | ||
lock_range: rerun.datatypes.Bool (order: 100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we sometimes prefer bool
over rerun.datatypes.Bool
and the other way around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should always prefer it in Components. We want to get to a place where components always forward to a datatype. Not only will this get us closer to a place where components are a thin semantic layer, it also means I don't have to implement bool serialization again and again in Python (and it won't be generated either for C++, Rust is the odd one out where we regenerate a lot of stuff all the time, to be fixed).
We're not consequent in this yet, but it's already happening e.g. with PanelExpanded
rerun_py/rerun_sdk/rerun/__init__.py
Outdated
"set_time_seconds", | ||
"set_time_sequence", | ||
"send_blueprint", | ||
"spawn", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder who has the type-sensitive sorter. I guess we'll find out in a PR soon enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, we won't 😆
added usage example that we can then also use for snippets. Also improved ergonomics to make this possible in the first place |
What
Usage example:
Changed codegen type definition:
Added the necessary serialization code and snippets. More aggressively using datatypes now to reduce amount of serialization code we need to write in Python.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.