Codegen for space view python blueprint classes #6100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
commented
Apr 24, 2024
| @@ -0,0 +1,4 @@ | |||
| # DO NOT EDIT! This file is generated by crates/re_types_builder/src/lib.rs | |||
|
|
|||
| .gitattributes linguist-generated=true | |||
There was a problem hiding this comment.
there's no tests in here, this is silly
There was a problem hiding this comment.
not the only one though. not bothering with this right now
Wumpf
commented
Apr 24, 2024
jleibs
approved these changes
Apr 24, 2024
| @@ -68,28 +68,34 @@ impl Objects { | |||
| objects: resolved_enums.into_iter().chain(resolved_objs).collect(), | |||
| }; | |||
|
|
|||
| // Validate fields types: Archetype consist of components, everything else consists of datatypes. | |||
| // Validate fields types: Archetype consist of components, Space Views consist of archetypes, everything else consists of datatypes. | |||
There was a problem hiding this comment.
I can't help but wonder if "SuperArchetypes" (structured collections of archetype) are a generic things of which SpaceViews just happen to be the first example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Extends our codegen to accept a fourth object type, space views (in addition to datatypes/components/archetypes). Meaning we can do special codegen for space views now, making it easy to set them up consistently and define what properties a space view can be constructed from. Building up on the previous PR that exposed background3d color, this generates almost identical code now.
Doesn't add yet any new view properties - this is going to happen in a follow-up PR since it requires getting a few more things serializable and subsequently also testing.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.