-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow any pan/zoom in 2D spatial views #6089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah didn't notice this got drafted and started a review. Didn't come all that far yet :)
Co-authored-by: Andreas Reich <[email protected]>
I re-drafted it once you started finding bugs |
5222453
to
bdf6843
Compare
I think I fixed it now, but will add a test tomorrow, and add some comments for future improvements |
89d594f
to
60aea9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more things to clean up but then we're good to go!
Very happy to finally get this in, this gets is a much better position to do further improvements in 2D land
@@ -11,7 +11,7 @@ workspace = true | |||
|
|||
[dependencies] | |||
re_log = { workspace = true, features = ["setup"] } | |||
rerun = { path = "../../../crates/rerun", features = ["web_viewer"] } | |||
rerun = { path = "../../../crates/rerun", features = ["clap", "web_viewer"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not seeing any corresponding code changes, was it broken somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, running this test standalone did not compile.
scripts/ci/rust_checks.py
doesn't cover tests/rust
, just examples/rust
# Intentionally off-center to demonstrate that we support it | ||
principal_point=[0.45 * img_depth.shape[1], 0.55 * img_depth.shape[0]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trying to process whether this makes e.g. length of depth rays incorrect for the data at hand 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't know the true pinhole for the dataset, anything we use is a guess
What
By default the bounds are centered:
Before:
After:
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.