Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to Python examples #6080

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix links to Python examples #6080

merged 3 commits into from
Apr 23, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Apr 23, 2024

What

☝🏻

broken by #5966

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI 🪳 bug Something isn't working and removed 🚢 CI labels Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

Deployed docs

Commit Link
8bc15ca https://landing-6vn5e5cbz-rerun.vercel.app/docs

@teh-cmc teh-cmc self-requested a review April 23, 2024 10:24
@teh-cmc
Copy link
Member

teh-cmc commented Apr 23, 2024

Looking at the remaining ones.

@teh-cmc teh-cmc merged commit b9eb600 into main Apr 23, 2024
29 of 30 checks passed
@teh-cmc teh-cmc deleted the antoine/fix-example-links branch April 23, 2024 10:37
@emilk
Copy link
Member

emilk commented Apr 23, 2024

I ran rg "examples/.*main.py" and:

This script should be fixed:

scripts/run_all.py
124:        for main_path in glob("examples/python/**/main.py"):

These links will break on next release, but it's unclear how we should fix that

examples/cpp/external_data_loader/README.md
3:python: https://github.com/rerun-io/rerun/tree/latest/examples/python/external_data_loader/main.py

examples/rust/external_data_loader/README.md
3:python: https://github.com/rerun-io/rerun/tree/latest/examples/python/external_data_loader/main.py

examples/python/external_data_loader/README.md
3:python: https://github.com/rerun-io/rerun/tree/latest/examples/python/external_data_loader/main.py

docs/content/reference/sdk-operating-modes.md
93:Check out our [dedicated example](https://github.com/rerun-io/rerun/tree/latest/examples/python/stdio/main.py).

docs/content/getting-started/data-in/python.md
16:At any time, you can checkout the complete code listing for this tutorial [here](https://github.com/rerun-io/rerun/tree/latest/examples/python/dna/main.py) to better keep track of the overall picture.

@abey79
Copy link
Member Author

abey79 commented Apr 23, 2024

run_all.py is fully broken, not just paths:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants