Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable background color from python code (POC for space view properties from code) #6068

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 22, 2024

What

This is primarily a quick exploration of our ideas on how to log blueprint from (python) code. It worked all well and arrived in a shippable state!

The next thing to figure out is how we streamline this with codegen while still preserving all the flexibility that is demonstrated by the different ways of constructing Background3D here (construction as well as component name).

Great time for feedback on the general direction!

Screen.Recording.2024-04-22.at.17.39.45.mov

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf changed the title Configurable background color from blueprint (POC for properties from code) Configurable background color from python code (POC for space view properties from code) Apr 22, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but probably deserves some sort of docs, e.g. a snippet

@Wumpf
Copy link
Member Author

Wumpf commented Apr 23, 2024

Yeah we need to figure out a system of snippets & docs for space view blueprints in general. I'll note down a few things in tickets and add it to the planning

@Wumpf
Copy link
Member Author

Wumpf commented Apr 23, 2024

captured in #6082

Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how straight-forward this is!

My only question is if we want to formalize calling these things "properties"... I don't have a better name but this name will show up a bunch of places as a generic building block for all space views so we should at least think about it a bit.

@Wumpf
Copy link
Member Author

Wumpf commented Apr 23, 2024

we talked about this on our daily and it looks like "(Space) View Properties" is sticking around :)

@Wumpf Wumpf merged commit ab71028 into main Apr 23, 2024
39 checks passed
@Wumpf Wumpf deleted the andreas/set-spaceview-prop-poc branch April 23, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants