Replace hyper with tiny_http to serve http files for serve functionality
#6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
dependencies
5 tasks
emilk
reviewed
Apr 19, 2024
This was referenced Apr 22, 2024
Wumpf
added a commit
that referenced
this pull request
Apr 22, 2024
### What Rust users now no longer need to ensure to have tokio runtime set up when using `serve`. * Fixes #5907 * Direct follow-up / merges into #6042 Last PR in a series of PRs for removal of the tokio runtime: * removes need for tokio in re_sdk_comms *similar to the refactor in re_ws_comms only in spirit - a lot simpler: no fancy broadcast, no other libraries involved. Just a bunch of threads hammering on blocking sockets). * remove remaining usages of async in this context * removes tokio need from all documentation ----- Dependency count `0.15.1` -> last friday `d90ed2f7e`-> `this pr` * `cargo build -p rerun --no-default-features` 225 -> 274 -> 275 dependencies * `cargo build -p rerun -F default` 361 -> 364 -> 364 dependencies * `cargo build -p rerun -F web_viewer` 409 -> 412 -> 374 dependencies Notes: * 0.15.1 already regressed quite a bit compared back to January: #4824 * we currently have a few temporary crates while migrating to re_query2 which weren't present in 0.15 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6043?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6043?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6043) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The prime motivator for this is to fix the need for setting up a tokio runtime every time someone calls serve.
Pro:
Con:
rerun-wasm-size:http header)There's some loose ends for final tokio removal which are tied up in #6043
(testing was mostly done on that pr and a little bit in isolation here as well to track down the download progress bar issues)
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.