re_web_viewer_server
no longer needs tokio, split out sync code path
#6030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
re_ws_comms
to work withoutasync
&tokio
runtime #6005tokio
#5907Removes tokio dependency from re_web_viewer_server:
WebViewerServer
no longer uses tokio internally, instead usefuture_channel::oneshot
for shutdownWebViewerServerHandle
is now optional (but default enabled) and spawns a thread that internally uses the tiny pollster cratere_web_viewer_server
's main file - it's not used by any test and may thus rotre_sdk_comms
which is very similar in nature tore_ws_comms
.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.