Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re_web_viewer_server no longer needs tokio, split out sync code path #6030

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 18, 2024

What

Removes tokio dependency from re_web_viewer_server:

  • async WebViewerServer no longer uses tokio internally, instead use future_channel::oneshot for shutdown
  • WebViewerServerHandle is now optional (but default enabled) and spawns a thread that internally uses the tiny pollster crate
  • removed re_web_viewer_server's main file - it's not used by any test and may thus rot
    • this allows us to also remove the clap dependency from this crate

⚠️ Rerun serve/connect still needs a tokio runtime with this change ⚠️: Likely the last piece after this is re_sdk_comms which is very similar in nature to re_ws_comms.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality include in changelog labels Apr 18, 2024
@Wumpf Wumpf force-pushed the andreas/re_web_viewer_server-tokio-removal branch from 39edc76 to d97ebe2 Compare April 18, 2024 10:22
why did this not show up before?
@Wumpf Wumpf merged commit 702c992 into main Apr 18, 2024
31 checks passed
@Wumpf Wumpf deleted the andreas/re_web_viewer_server-tokio-removal branch April 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants