Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all dev/ci requirements.txt and fully replace with pixi #5939

Merged
merged 12 commits into from
Apr 12, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 12, 2024

What

In the process cleans up quite a bit more ci to use the pixi environment consequently.

Note that the process I followed here was essentially:

  • pick a requirements.txt file
  • check for each of its package if it's already in pixi
    • if not, try adding it as conda package to pixi
      • if not add it as pypi package to pixi
      • try documenting who uses it
  • repeat until requirements.txt file is empty
  • remove mentions of the requirements.txt file, ensure that python invocations below are using pixi

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

Copy link

github-actions bot commented Apr 12, 2024

Deployed docs

Commit Link
806c68a https://landing-bezia709z-rerun.vercel.app/docs

@Wumpf Wumpf marked this pull request as ready for review April 12, 2024 10:01
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if tested, and if you have searched for the removed scripts so that they are not referred to from anywhere

@Wumpf
Copy link
Member Author

Wumpf commented Apr 12, 2024

if you have searched for the removed scripts

I did, but given my track record I better do another round 😅

@Wumpf Wumpf merged commit 97a45d3 into main Apr 12, 2024
37 checks passed
@Wumpf Wumpf deleted the andreas/remove-dev-requirementstxt branch April 12, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace non-example requirements.txt files with pixi
2 participants