Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove justfile & fully replace remaining commands with pixi #5892

Merged
merged 13 commits into from
Apr 10, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 10, 2024

What

Has a few judgment calls on what is no longer needed, but preserves most of what we had.
Notably removes py-requirements command for the time being - the hope is that #5890 will fix things. (porting it proved difficult)
See

Other things in here:

  • taplo (toml formatting) was very slow since despite extensive 'exclude' list it looked at too many files. Turned it around to 'include' things and it's a LOT faster now
  • Updated Ruff & removed last use of blackdoc. The only thing we're not properly catching with this now is too long lines, I figured it's not worth keeping it around just for that.
  • various cleanups of pixi.toml file: trying to make commands a bit more consistent overall

Tested on:

  • mac
  • windows

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk self-requested a review April 10, 2024 14:02
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fan-fucking-tastic!

pixi.toml Outdated Show resolved Hide resolved
rerun_py/pyproject.toml Show resolved Hide resolved
@Wumpf Wumpf merged commit 5d5749d into main Apr 10, 2024
34 checks passed
@Wumpf Wumpf deleted the andreas/remove-justfile branch April 10, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove justfile
2 participants