Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update egui_commonmark #5864

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Update egui_commonmark #5864

merged 1 commit into from
Apr 10, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 9, 2024

What

Seems pretty safe - i tested a handful of examples, and all their inline markdown looks as good or better.

https://github.com/lampsitter/egui_commonmark/blob/master/CHANGELOG.md

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added ui concerns graphical user interface dependencies concerning crates, pip packages etc include in changelog labels Apr 9, 2024
@emilk emilk changed the base branch from release-0.15.0 to main April 9, 2024 15:01
Seems pretty safe - i tested a handful of examples, and all their
inline markdown looks as good or better.

https://github.com/lampsitter/egui_commonmark/blob/master/CHANGELOG.md
@emilk emilk force-pushed the emilk/egui_commonmark-update branch from 0ee9740 to a51966d Compare April 9, 2024 15:03
@emilk emilk merged commit 82993da into main Apr 10, 2024
34 of 36 checks passed
@emilk emilk deleted the emilk/egui_commonmark-update branch April 10, 2024 08:15
emilk added a commit that referenced this pull request Apr 10, 2024
### What
Seems pretty safe - i tested a handful of examples, and all their inline
markdown looks as good or better.

https://github.com/lampsitter/egui_commonmark/blob/master/CHANGELOG.md

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[rerun.io/viewer](https://rerun.io/viewer/pr/5864)
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5864?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5864?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5864)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants