Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix draw_order not working #5794

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Fix draw_order not working #5794

merged 6 commits into from
Apr 4, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 4, 2024

What

Draw order was not doing anything on 0.14!

The underlying issue was that the depth offset context system which converts draw order to depth offsets didn't iterate any entities since it used a iterator for entities.
This means we're now iterating a much larger entity set. I checked with the "many entities" manual test and the context system takes about 0.5ms for me in release there. This is kinda bad but it's not a big dent here (unfortunately) and it runs in parallel to the much slower transform context system.

This PR moves the (also broken due to heuristic changes) test from "api_test" to a release check with a description what should be observable.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release labels Apr 4, 2024
@Wumpf Wumpf requested a review from jleibs April 4, 2024 16:36
@Wumpf Wumpf force-pushed the andreas/draw-order-fixes branch from 38f6275 to c9e6293 Compare April 4, 2024 16:51
@Wumpf Wumpf merged commit ac9f767 into main Apr 4, 2024
34 checks passed
@Wumpf Wumpf deleted the andreas/draw-order-fixes branch April 4, 2024 21:17
@emilk emilk changed the title Fix draw order not working Fix draw_order not working Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants