Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Draw order was not doing anything on 0.14!
The underlying issue was that the depth offset context system which converts draw order to depth offsets didn't iterate any entities since it used a iterator for entities.
This means we're now iterating a much larger entity set. I checked with the "many entities" manual test and the context system takes about 0.5ms for me in release there. This is kinda bad but it's not a big dent here (unfortunately) and it runs in parallel to the much slower transform context system.
This PR moves the (also broken due to heuristic changes) test from "api_test" to a release check with a description what should be observable.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewer