Always show welcome screen, but sometimes fade it in #5787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to be that `rerun --web-viewer` didn't show the welcome screen, which is super annoying when testing. It also feels very brittle to sometimes show it, and sometimes not, and to keep track if we've ever seen a recording, etc. SO: the new design is much simpler. We always show the welcome screen, but if we expect data to come streaming in at any second we delay it for a a fraction of a second and then fade it in. This prevents the problem of a flashing welcome screen before showing actual user data. This fade-in was proposed during the initial design of the welcome screen, but we never got to it. This replaces `--skip-welcome-screen` with `--fade-in-welcome-screen`. You can test it with `pixi run rerun ----fade-in-welcome-screen`
emilk
force-pushed
the
emilk/always-show-welcome-screen
branch
from
7d5fa67 to
912f24f
Compare
jleibs
approved these changes
Apr 4, 2024
Co-authored-by: Jeremy Leibs <[email protected]>
emilk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
just rerun-webshould show the welcome screen #4317It used to be that
rerun --web-viewerdidn't show the welcome screen, which is super annoying when testing.It also feels very brittle to sometimes show it, and sometimes not, and to keep track if we've ever seen a recording, etc.
It also feel inconsistent with how the welcome screen is now just another app in the recordings panel.
So the new design is much simpler. We always show the welcome screen, but if we expect data to come streaming in at any moment, we delay the welcome screen for a a fraction of a second and then fade it in. This prevents the problem of a flashing welcome screen before showing actual user data.
This fade-in was proposed during the initial design of the welcome screen, but we never got to it.
This replaces
--skip-welcome-screenwith--fade-in-welcome-screen.You can test it with
pixi run rerun ----fade-in-welcome-screenChecklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewer