-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all loaded applications in recordings panel #5766
Conversation
First off I think the whole experience is so much better than before! I don't like having the welcome screen permanently in the recordings list but feel like it's worth it to try it out with one of the following modifications: EasiestAdd an option to the options menu to exclude the welcome screen from the recordings list. BestMake it possible to remove the welcome screen as well (feels alot more like VSCode. If all recordings are removed, have an empty screen with a very subtle button to load the welcome screen + add an action to the command palette & menu to bring it back. Browny points for making it blueprint configurable to include at all. |
// Find all recordings with this app id | ||
let recordings: Vec<&EntityDb> = ctx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have the blueprints here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but could also be very confusing. Do we show all the blueprints? Or just the active and default ones? What if the active and default are the same? Etc. I opted to keep it simple for now.
What
Being able to quickly select the welcome screen is super useful while exploring examples, and for testing.
It is also the natural place to return to to find the links to the docs, and maybe more stuff in the future.
Demo
At the start here I have pulled in a blueprint for arkit, but no recording for it
show-welcome-screen-in-blueprint-panel-2.mp4
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewer