Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all loaded applications in recordings panel #5766

Merged
merged 15 commits into from
Apr 4, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 3, 2024

What

  • Show all loaded applications in the recordings panel
    • Even those with no recordings
    • Even welcome screen
  • Close application when last recording of that app is closed
  • Add button to close all recordings in an application
  • Make applications selectable
  • When loading a blueprint, switch to its application

Being able to quickly select the welcome screen is super useful while exploring examples, and for testing.
It is also the natural place to return to to find the links to the docs, and maybe more stuff in the future.

Demo

At the start here I have pulled in a blueprint for arkit, but no recording for it

show-welcome-screen-in-blueprint-panel-2.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added ui concerns graphical user interface include in changelog labels Apr 3, 2024
@emilk emilk marked this pull request as ready for review April 3, 2024 18:08
@nikolausWest
Copy link
Member

First off I think the whole experience is so much better than before!

I don't like having the welcome screen permanently in the recordings list but feel like it's worth it to try it out with one of the following modifications:

Easiest

Add an option to the options menu to exclude the welcome screen from the recordings list.

Best

Make it possible to remove the welcome screen as well (feels alot more like VSCode. If all recordings are removed, have an empty screen with a very subtle button to load the welcome screen + add an action to the command palette & menu to bring it back. Browny points for making it blueprint configurable to include at all.

Comment on lines +31 to +32
// Find all recordings with this app id
let recordings: Vec<&EntityDb> = ctx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have the blueprints here as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but could also be very confusing. Do we show all the blueprints? Or just the active and default ones? What if the active and default are the same? Etc. I opted to keep it simple for now.

crates/re_viewer_context/src/store_hub.rs Show resolved Hide resolved
@emilk emilk merged commit df4c130 into main Apr 4, 2024
34 checks passed
@emilk emilk deleted the emilk/select-app-id branch April 4, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a blueprint appears to do nothing if you have no rrd files Make App ID selectable
3 participants