Go back to example page with browser Back-button #5750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This uses the History API to manipulate the web history.
When leaving the example page, two entries in the history are added:
?examples
(shows the examples)?url=https://….rrd
(the url for the example)This is then parsed on
popstate
. We thus support both going forward and back in history.This is not perfect, but a lot better than before.
Best reviewed commit by commit.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewer