Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a hang on linux by always create the renderer, even when we have no store_view #5724

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 29, 2024

What

All this does is re-orders the calls so that we always create a renderer and call begin_frame / before_submit even if the case where we have no StoreView.

In theory this uses a few more resources when skipping the welcome screen, but practically in almost all cases this is only for a few frames until log-data starts arriving.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@jleibs jleibs added ui concerns graphical user interface include in changelog labels Mar 29, 2024
@jleibs jleibs added this to the 0.15 milestone Mar 29, 2024
@jleibs jleibs marked this pull request as ready for review March 29, 2024 13:49
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to remove that flag. We should always show the welcome screen imho. I miss it when running pixi run rerun-web

@jleibs
Copy link
Member Author

jleibs commented Mar 29, 2024

I want to remove that flag. We should always show the welcome screen imho.

The flag serves a valid purpose when the SDK is spawning a viewer it's about to send data to, to avoid a visual glitch... other than that though we should never use it. I wouldn't have expected it to apply to pixi run rerun-web though.

@jleibs jleibs merged commit a547820 into main Mar 29, 2024
57 of 90 checks passed
@jleibs jleibs deleted the jleibs/avoid_hang_on_launch branch March 29, 2024 15:29
@emilk emilk added 🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants