Avoid a hang on linux by always create the renderer, even when we have no store_view #5724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
rerun --skip-welcome-screen
causes Rerun to hang on launch #5283All this does is re-orders the calls so that we always create a renderer and call begin_frame / before_submit even if the case where we have no StoreView.
In theory this uses a few more resources when skipping the welcome screen, but practically in almost all cases this is only for a few frames until log-data starts arriving.
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io