-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce rr.notebook_show()
to simplify notebook experience
#5715
Conversation
2cee302
to
07647f0
Compare
rr.show_notebook()
to simplify notebook experiencerr.notebook_show()
to simplify notebook experience
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
- Almost feels like we should add a check to the release checklist which is basically just a readme saying "run the notebook example!".
- The notebook example's README still mention
rr.memory_recording
and such.
The last two cells fail with the following for me:
even though I'm running everything off of your branch and going through the local webserver:
Also I don't understand how I can have a version mismatch if it's all running off of this branch? 🤔
The embedded viewer is constantly saying Waiting for data...
even though the data has been loaded:
Finally, clicking on the Rerun icon in the top left (the main menu) will always crash the view:
I'm starting to feel like all of these issues are the result of that version mismatch and that I must be doing something wrong but I can't see what?
That was indeed the case. I had to run This fixes my versioning issues, the last two cells, and even the menu crash! Only the "waiting for data" thingy is left. |
What
As part of adding blueprint support to notebooks, I realized the experience of creating and logging memory recordings felt very incongruous with the normal rerun workflow.
I introduced a new mechanism
rr.notebook_show()
, which uses the MemoryRecording behind the scenes, but doesn't require users to be aware of it.All Blueprint types now support
_repr_html_
and show the currently active recording stream.Uncovered several existing sharp-corners with notebooks:
Lastly, updated the notebook cube example to use the new style:
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io