Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons for Blueprint and Data Source #5713

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Add icons for Blueprint and Data Source #5713

merged 3 commits into from
Mar 28, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 27, 2024 •
edited by github-actions bot
Loading

What

Screenshot 2024-03-27 at 18 25 36

Some other alternatives
Screenshot 2024-03-27 at 18 24 38

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 27, 2024
abey79
abey79 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I'm not super fond of the datasource icon–it looks too much like the link one, but it's not that critical anyways and we can always iterate later.

image

crates/re_data_ui/src/item_ui.rs
Comment on lines +616 to +619
let icon = match entity_db.store_kind() {
re_log_types::StoreKind::Recording => &icons::RECORDING,
re_log_types::StoreKind::Blueprint => &icons::BLUEPRINT,
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move that to StoreKind::icon()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't have re_log_types depend on re_ui

crates/re_ui/data/icons/recording.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This icon has weird artefacts

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wth… that's annoying.
And I can't find the original in Figma

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have created the icon myself with some screenshotting in #4761 instead of waiting for Mårten to create one 😬

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My gimp skills solved it

@emilk emilk merged commit 34e3fec into main Mar 28, 2024
34 checks passed
@emilk emilk deleted the emilk/blueprint-data-source-icons branch March 28, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create icons for Blueprint and Data Source
2 participants
@emilk @abey79