Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build release .wasm with debug symbols #5708

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Build release .wasm with debug symbols #5708

merged 1 commit into from
Mar 27, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 27, 2024

What

This makes the compressed .wasm around 300kB bigger (+5%). In return we get:

  • Good callstacks on panics
  • In-browser profiling using the normal browser profiling tools

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🕸️ web regarding running the viewer in a browser 🧑‍💻 dev experience developer experience (excluding CI) 🚀 performance Optimization, memory use, etc include in changelog labels Mar 27, 2024
Copy link

Size changes

Name main 5708/merge Change
Wasm 18.67 MiB 20.08 MiB +7.55%

@emilk
Copy link
Member Author

emilk commented Mar 27, 2024

Here's a screenshot of the chromium profiler on one frame of the OPF example

Screenshot 2024-03-27 at 16 12 00

@emilk emilk merged commit a06cbdf into main Mar 27, 2024
38 of 39 checks passed
@emilk emilk deleted the emilk/relwithdeb-wasm branch March 27, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) include in changelog 🚀 performance Optimization, memory use, etc 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants