-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated READMEs for examples: LLM Embedding-Based Named Entity Recognition, nuScenes, Objectron, Open Photogrammetry Format, Raw Mesh #5653
Conversation
…to andreasnaoum-examples-batch2
Size changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some background sections and we should also add the blueprint code sections where applicable. @jleibs, do you think we should add those directly in this PR or as a separate PR?
Maybe another PR for blueprints? If we wait for the blueprints, the readmes will be delayed from appearing on the website. |
let's do this in a separate pass. That's a problem with all updated readmes right now, including others. |
@andreasnaoum all the example blueprint updates landed already, so whatever we want to write about blueprint in the readme can be done already now (but as I wrote before, let's do that in a separate pr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't do a full review, but previous concerns seem to be all addressed, so let's move on
I'm mopping up the remaining ci failures |
Updated READMEs for the examples:
What
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io