Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated READMEs for examples: LLM Embedding-Based Named Entity Recognition, nuScenes, Objectron, Open Photogrammetry Format, Raw Mesh #5653

Merged
merged 11 commits into from
Apr 4, 2024

Conversation

andreasnaoum
Copy link
Contributor

@andreasnaoum andreasnaoum commented Mar 22, 2024

Updated READMEs for the examples:

  • LLM Embedding-Based Named Entity Recognition
  • nuScenes
  • Objectron
  • Open Photogrammetry Format
  • Raw Mesh

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@andreasnaoum andreasnaoum added 📖 documentation Improvements or additions to documentation ui concerns graphical user interface examples Issues relating to the Rerun examples include in changelog labels Mar 22, 2024
Copy link

github-actions bot commented Mar 22, 2024

Size changes

Name main 5653/merge Change
rrt-star.rrd 10 MiB 35.43 MiB +254.30%

Copy link
Member

@nikolausWest nikolausWest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some background sections and we should also add the blueprint code sections where applicable. @jleibs, do you think we should add those directly in this PR or as a separate PR?

examples/python/nuscenes/README.md Show resolved Hide resolved
examples/python/objectron/README.md Show resolved Hide resolved
@andreasnaoum
Copy link
Contributor Author

Maybe another PR for blueprints? If we wait for the blueprints, the readmes will be delayed from appearing on the website.

@Wumpf
Copy link
Member

Wumpf commented Apr 4, 2024

should also add the blueprint code sections where applicable

let's do this in a separate pass. That's a problem with all updated readmes right now, including others.

@Wumpf
Copy link
Member

Wumpf commented Apr 4, 2024

@andreasnaoum all the example blueprint updates landed already, so whatever we want to write about blueprint in the readme can be done already now (but as I wrote before, let's do that in a separate pr)

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't do a full review, but previous concerns seem to be all addressed, so let's move on

@Wumpf Wumpf dismissed nikolausWest’s stale review April 4, 2024 09:20

was addressed

@Wumpf
Copy link
Member

Wumpf commented Apr 4, 2024

I'm mopping up the remaining ci failures

@Wumpf Wumpf merged commit dd40fa8 into main Apr 4, 2024
31 checks passed
@Wumpf Wumpf deleted the andreasnaoum-examples-batch2 branch April 4, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants