Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not logging 3D gesture z component correctly in Gesture Detection example #5630

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

andreasnaoum
Copy link
Contributor

@andreasnaoum andreasnaoum commented Mar 21, 2024

Thanks to @Wumpf, we identified a problem in the 3D view and fixed it. It was a typo (y instead z) and made the view look 2D instead of 3D.

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@andreasnaoum andreasnaoum added examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 21, 2024
@Wumpf Wumpf changed the title Fix a typo in 3d coordinates - Gesture Detection Example Fix not logging 3D gesture z component correctly in Gesture Detection example Mar 21, 2024
@Wumpf Wumpf added 🪳 bug Something isn't working include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 21, 2024
@Wumpf Wumpf merged commit 62c79c7 into main Mar 21, 2024
29 of 33 checks passed
@Wumpf Wumpf deleted the andreasnaoum-gesture-detection-fix-3d branch March 21, 2024 15:55
@Wumpf
Copy link
Member

Wumpf commented Mar 21, 2024

(skipped ci on this for obvious reasons)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants