Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select active recording if nothing else is selected #5627

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 21, 2024

What

If nothing is selected (or user presses escape), the active recording gets selected.

In a future PR I will improve the contents of the selection panel when a recording is selected, e.g. show the blueprints in the recording etc, but for that I need to do some refactors first.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added ui concerns graphical user interface include in changelog labels Mar 21, 2024
@Wumpf Wumpf self-requested a review March 21, 2024 15:46
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite happy with the place where you put this in. It's subtle but it creates inconsistent behavior when the selection panel is not shown: When you hide the selection panel pressing escape now has different semantics than when it is shown.
I think this should be handled in a more central place that is always executed.

I also thought this would create strange empty-entries in the selection history still, but that's not the case it seems, so all good on that front!

@emilk emilk requested a review from Wumpf March 21, 2024 16:48
@emilk
Copy link
Member Author

emilk commented Mar 21, 2024

I moved it to just before showing the selection panel.

Copy link

Size changes

Name main 5627/merge Change
rrt-star.rrd 9.13 MiB (deleted) -100%

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Wumpf Wumpf merged commit d70a0f5 into main Mar 21, 2024
34 checks passed
@Wumpf Wumpf deleted the emilk/select-recording branch March 21, 2024 18:46
@Wumpf
Copy link
Member

Wumpf commented Mar 21, 2024

rrt-star.rrd got added on main. size changes is confused but that but that's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants