Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support toggling item visibility on touch screens #5624

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 21, 2024

What

You can now click the "hover" buttons on list items on touch screens, by first selecting the item, which will now make the buttons appear.

I also did a few other improvements.

Best reviewed commit by commit

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added ui concerns graphical user interface include in changelog labels Mar 21, 2024
@emilk emilk marked this pull request as ready for review March 21, 2024 14:43
@emilk
Copy link
Member Author

emilk commented Mar 21, 2024

Tested on iPhone, and works

@Wumpf Wumpf self-requested a review March 21, 2024 15:29
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I think that's also strictly an improvement for non-touchscreens (:

@Wumpf Wumpf merged commit 4a1f6a4 into main Mar 21, 2024
34 of 35 checks passed
@Wumpf Wumpf deleted the emilk/list-item-fixes branch March 21, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants