Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the height of the tab bars and side panel titles #5609

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Reduce the height of the tab bars and side panel titles #5609

merged 3 commits into from
Mar 21, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Mar 20, 2024 •
edited by github-actions bot
Loading

What

Small step towards a more efficient use of vertical space. Set to 24px, down from 28px. Now on par with ListItem:

image image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@github-actions GitHub Actions
Copy link

Size changes

Name main 5609/merge Change
re_sdk --no-default-features 117 crates 111 crates -6 crates

teh-cmc
teh-cmc approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a small improvement imo, which is better than no improvement 🤷

Wumpf
Wumpf approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. of all the vertical size improvements this feels the most like a no-brainer

crates/re_ui/src/lib.rs Outdated
@@ -184,7 +184,7 @@ impl ReUi {
/// Height of the title row in the blueprint view and selection view,
/// as well as the tab bar height in the viewport view.
pub fn title_bar_height() -> f32 {
28.0 // from figma 2022-02-03
24.0 // from figma 2022-02-03
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that comment is surely wrong now 😄

@abey79 abey79 marked this pull request as ready for review March 21, 2024 10:48
@abey79 abey79 changed the title [TBD] Set the tab and panel title bar height to 24px Reduce the height of the the tab bars and side panel titles Mar 21, 2024
@abey79 abey79 merged commit 3844083 into main Mar 21, 2024
38 of 40 checks passed
@abey79 abey79 deleted the antoine/title-bar-24 branch March 21, 2024 11:50
@jleibs jleibs changed the title Reduce the height of the the tab bars and side panel titles Reduce the height of the tab bars and side panel titles Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abey79 @Wumpf @teh-cmc