Refactor Selection
using IndexMap
and make it more encapsulated
#5569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR change
Selection
to use anIndexMap<Item, Option<SelectedSpaceContext>>
instead of aVec<(Item, Option<SelectedSpaceContext>)
. This is a much better model for the selection that we currently have (Item
may not be duplicated, even with different space context) and paves the way for a clean "remove" API (needed by #5465).The choice of
IndexMap
is motivated by keeping the selection in the click-order, as was previously the case withVec
. This was a pre-existing transitive dependency.Checklist
main
build: app.rerun.ionightly
build: app.rerun.io