Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where an incorrect 3D space view origin could be suggested #5565

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Mar 18, 2024

What

Fix a bug introduced in #5411 and #5423 where the wrong origin would be suggested when creating a 3D space view from an entity part of a 2D space view. Quoting the original PR:

For 3D space views: the origin of the subspace that contains the selected entities common ancestor, or, if that one is rooted on a pinhole, the origin of the parent sub-space. Further, if a ViewCoordinate is logged in between the subspace origin and the common ancestor, then it's used as suggested origin. In most case, that means /, unless a DisconnectedSpace is encountered.

The part of that logic where we check for a ViewCoordinate in the parent subspace was implemented incorrectly, which resulted in check_context_menu_suggested_origin to fail. With this PR, this test now passes.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@abey79 abey79 added 🪳 bug Something isn't working ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 18, 2024
@Wumpf Wumpf self-requested a review March 18, 2024 16:24
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah subtle! good find and fix

@abey79 abey79 merged commit cb19989 into main Mar 18, 2024
37 of 38 checks passed
@abey79 abey79 deleted the antoine/fix-origin-suggestion branch March 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants